fix: cache version probe result to prevent reconciliation deadlock#175
Merged
GrigoryPervakov merged 1 commit intoClickHouse:mainfrom Apr 28, 2026
Merged
Conversation
5ffb3b1 to
f057f92
Compare
Contributor
Author
|
@GrigoryPervakov two points, let me know your thoughts.
|
GrigoryPervakov
approved these changes
Apr 28, 2026
Member
Let's keep it as it works now. For a production environment, it makes sense to use a full version tag.
I thought about such scenarios, and I can't find any realistic cases where a successful Job produces invalid output, and this is not a persistent issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When a completed version-probe Job's Pod is garbage-collected before the operator reads the termination message, readVersionFromJob returns a hard error on every reconcile. Since the Job is complete (not recreated) and the Pod is gone (can't be read), the reconciliation loop blocks indefinitely.
What
Related Issues
Fixes #170